React Component Update #14
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is to update the current countdown-timer to extend React Component. This is a future proofing solution to aid the use of ES6 classes. Facebook recommends the deprecation of ReactClass, I suggest we follow suit.
Also fixes errors that the current implementation has. The following are listed below.
When adding props to component, passing them results in the timer restarting due to colliding logic in
componentWillReceivePropsMisuse of the constructor (as per @rloomba implementation)
-- I believe that although this adds the use of es6, it's necessary as an update to the current branch since the current state is basically unusable by any visitors using up to date libraries (most people I would presume).