WIP: parallel version of multi_localminmax.hxx #203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update from Parallelization@Vigra
Added parallel version of multi_pointoperators.hxx
minhb
changed the title
minhb
changed the title
Owner
|
This PR cannot be used as is because we abandoned OpenMP in favor of std::thread. But it still contains lots of useful code, so I keep it open for now. |
ukoethe
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I updated the parallel version of the node iteration section in the following functions:
The test file is test/openmp/test_omp_multi_localminmax.cxx
There are two issues I have:
breakstatement. I think, in the parallel region when one thread hitsbreakstatement, the others should stop executing their loop iterations. This could save us some useless work.Although, I would like to make this pull request to discuss about the parallel version of above functions.
Remark: I would like to make a separate pull request for this issue. Unfortunately, the previous commits still stayed in this pull request. So, please consider changes in only two files: test/openmp/test_omp_multi_localminmax.cxx and include/vigra/multi_localminmax.hxx .
Best regards,
Minh