Fix downstream cmake build #561
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Do you know why the CIs are failing? is it actually due to a change you made? |
Collaborator
Thank you very much for this CMake is quite difficult to always stay up to date with! |
Collaborator
|
I unfortunately think the failure is real given that I restarted the builds fresh in: and they are passing. |
Author
|
I agree, just need to investigate where abouts in the buildsystem it's no
longer linking openEXR, or why not, will try to do in the next couple of
days
…On Wed, Mar 27, 2024 at 12:16 PM Mark Harfouche ***@***.***> wrote:
I unfortunately think the failure is real given that I restarted the
builds fresh in:
#559 <#559>
and they are passing.
—
Reply to this email directly, view it on GitHub
<#561 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAIKUMVJQP73EKL5B6CZY3DY2K2C3AVCNFSM6AAAAABFDTWHXKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRSGYZDMNBZGY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
hmaarrfk
reviewed
Aug 10, 2024
| # need to make sure we can resolve the target names | ||
| # that end up in VigraConfig.cmake | ||
| # If we found OpenEXR by targets. | ||
| find_dependency(OpenEXR QUIET) |
Collaborator
There was a problem hiding this comment.
Suggested change
| find_dependency(OpenEXR QUIET) | |
| find_dependency(OpenEXR CONFIG QUIET) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch addresses something of an edge case but which crops up in modern linux distros:
In the case where downstream packages consume Vigra via CMake configuration files, AND you built it with openEXR AND that openEXR installation provided cmake configuration files, the vigraTargets.cmake file that is generated contains openEXR target names rather than absolute library paths.
In this case, we need to find openEXR in the config file transitively, otherwise downstream builds will fail because those targets don't exist.
For good measure, while we're there, in this case also modernise how we link in the targets (i.e. fully via target_link_libraries rather than manual include directories variables etc).