Skip to content

Conversation

@WashingtonKK
Copy link
Contributor

@WashingtonKK WashingtonKK commented Jan 13, 2026

What type of PR is this?

This is an enhancement

What does this do?

Updates the cube permissions file to match the cube specific permissions described in spicedb schema

Which issue(s) does this PR fix/relate to?

Have you included tests for your changes?

Did you document any new/modified features?

Notes

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't need to track this file

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

- list_channels: channel_read_permission
- create_groups: group_create_permission
- list_groups: group_read_permission
llm_operations:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this grouping valid? does smq expect this

- list_channels: channel_read_permission
- create_groups: group_create_permission
- list_groups: group_read_permission
- create: llm_create_permission
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this tested, I see key value pairs which have duplicates

Comment on lines 49 to 78
- add: llm_manage_role_permission
- remove: llm_manage_role_permission
- update: llm_manage_role_permission
- retrieve: llm_view_role_users_permission
- retrieve_all: llm_view_role_users_permission
- add_actions: llm_manage_role_permission
- list_actions: llm_view_role_users_permission
- check_actions_exists: llm_view_role_users_permission
- remove_actions: llm_manage_role_permission
- remove_all_actions: llm_manage_role_permission
- add_members: llm_add_role_users_permission
- list_members: llm_view_role_users_permission
- check_members_exists: llm_view_role_users_permission
- remove_members: llm_remove_role_users_permission
- remove_all_members: llm_remove_role_users_permission
- add: audit_log_manage_role_permission
- remove: audit_log_manage_role_permission
- update: audit_log_manage_role_permission
- retrieve: audit_log_view_role_users_permission
- retrieve_all: audit_log_view_role_users_permission
- add_actions: audit_log_manage_role_permission
- list_actions: audit_log_view_role_users_permission
- check_actions_exists: audit_log_view_role_users_permission
- remove_actions: audit_log_manage_role_permission
- remove_all_actions: audit_log_manage_role_permission
- add_members: audit_log_add_role_users_permission
- list_members: audit_log_view_role_users_permission
- check_members_exists: audit_log_view_role_users_permission
- remove_members: audit_log_remove_role_users_permission
- remove_all_members: audit_log_remove_role_users_permission
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this the correct way to use these, are these role operations

Comment on lines 53 to 84
# LLM roles operations
- llm_add: llm_manage_role_permission
- llm_remove: llm_manage_role_permission
- llm_update: llm_manage_role_permission
- llm_retrieve: llm_view_role_users_permission
- llm_retrieve_all: llm_view_role_users_permission
- llm_add_actions: llm_manage_role_permission
- llm_list_actions: llm_view_role_users_permission
- llm_check_actions_exists: llm_view_role_users_permission
- llm_remove_actions: llm_manage_role_permission
- llm_remove_all_actions: llm_manage_role_permission
- llm_add_members: llm_add_role_users_permission
- llm_list_members: llm_view_role_users_permission
- llm_check_members_exists: llm_view_role_users_permission
- llm_remove_members: llm_remove_role_users_permission
- llm_remove_all_members: llm_remove_role_users_permission
# Audit log roles operations
- audit_log_add: audit_log_manage_role_permission
- audit_log_remove: audit_log_manage_role_permission
- audit_log_update: audit_log_manage_role_permission
- audit_log_retrieve: audit_log_view_role_users_permission
- audit_log_retrieve_all: audit_log_view_role_users_permission
- audit_log_add_actions: audit_log_manage_role_permission
- audit_log_list_actions: audit_log_view_role_users_permission
- audit_log_check_actions_exists: audit_log_view_role_users_permission
- audit_log_remove_actions: audit_log_manage_role_permission
- audit_log_remove_all_actions: audit_log_manage_role_permission
- audit_log_add_members: audit_log_add_role_users_permission
- audit_log_list_members: audit_log_view_role_users_permission
- audit_log_check_members_exists: audit_log_view_role_users_permission
- audit_log_remove_members: audit_log_remove_role_users_permission
- audit_log_remove_all_members: audit_log_remove_role_users_permission
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stick to spice db, most of these do not exist

Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>
Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>
Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>
Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>
Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>
Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>
Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update permissions file to match cube

2 participants