CUBE_134 - Add attestation report to audit logs #137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SammyOina
requested changes
Jan 27, 2026
| func (t *InstrumentedTransport) setResponseHeaders(resp *http.Response, result *AttestationResult, atlsExpected bool) { | ||
| // Always set TLS details when available (for audit logging) | ||
| if result.TLSVersion != "" { | ||
| resp.Header.Set(headerTLSVersion, result.TLSVersion) |
Contributor
There was a problem hiding this comment.
check if nill and initialize if needed or this will panic
| func (t *InstrumentedTransport) setResponseHeaders(resp *http.Response, result *AttestationResult, atlsExpected bool) { | ||
| // Always set TLS details when available (for audit logging) | ||
| if result.TLSVersion != "" { | ||
| resp.Header.Set(headerTLSVersion, result.TLSVersion) |
Contributor
There was a problem hiding this comment.
check if nill and initialize if needed or this will panic
| func (t *InstrumentedTransport) setResponseHeaders(resp *http.Response, result *AttestationResult, atlsExpected bool) { | ||
| // Always set TLS details when available (for audit logging) | ||
| if result.TLSVersion != "" { | ||
| resp.Header.Set(headerTLSVersion, result.TLSVersion) |
Contributor
There was a problem hiding this comment.
check if nill and initialize if needed or this will panic
| } | ||
|
|
||
| // GetLastResult returns the last attestation result (thread-safe). | ||
| func (t *InstrumentedTransport) GetLastResult() *AttestationResult { |
Contributor
There was a problem hiding this comment.
Any caller who mutates the returned map would race with other goroutines accessing lastResult.Report.
SammyOina
approved these changes
Jan 28, 2026
Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>
Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>
Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>
Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>
WashingtonKK
force-pushed
the
cube-134
branch
from
8c09009 to
b1eaf2c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this do?
Which issue(s) does this PR fix/relate to?
Have you included tests for your changes?
Did you document any new/modified features?
Notes