fix: parse Ollama reasoning fields#3236
Merged
Merged
Conversation
This was referenced Jun 8, 2026
|
This is a necessary companion to #3228. Parsing the Ollama reasoning field properly ensures Qwen3 thinking models produce usable output instead of empty responses. The CI is green and the fix is clean - good to go. |
This was referenced Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
reasoningfields in OpenAI-compatible non-streaming and streaming responsesOPENAI_BASE_URLfor tagged Qwen model names and document local setupValidation
cargo fmt --all --checkcargo test -p api ollama_reasoning -- --nocapturecargo test -p api reasoning_content -- --nocapturecargo test -p api openai_compatible_client_honors_http_proxy_for_requests -- --nocapturecargo test -p api local_openai_gateway_strips_routing_prefix_and_preserves_extra_body_params -- --nocapturecargo test -p rusty-claude-cli qwen_invalid_model_hint_mentions_local_ollama_openai_base_url -- --nocapturecargo test -p rusty-claude-cli parses_single_word_command_aliases_without_falling_back_to_prompt_mode -- --nocapturecargo test --workspacecargo clippy --workspace --all-targetsOLLAMA_HOST=http://127.0.0.1:11434 ./rust/target/debug/claw --model gpt-oss:20b prompt "Reply exactly HELLO_WORLD_123"returnedHELLO_WORLD_123Notes
gpt-oss:20bandkimi-k2.6:cloud.