Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@
"eslint": "^9.17.0",
"tsx": "^4.19.2",
"typescript": "^5.7.2",
"vitest": "^2.1.8",
"vitest": "^4.0.18",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The vitest package is updated to v4, but the @vitest/coverage-v8 package is not. This version mismatch will cause a peer dependency conflict and break the CI build.
Severity: HIGH

Suggested Fix

To resolve the peer dependency conflict, update the @vitest/coverage-v8 package to a version compatible with vitest v4. Change @vitest/coverage-v8 from ^2.1.8 to ^4.0.18 in package.json.

Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: package.json#L66

Potential issue: The pull request updates `vitest` to version `^4.0.18` but leaves
`@vitest/coverage-v8` at `^2.1.8`. This creates a peer dependency conflict, as the older
coverage package requires a `vitest` version compatible with v2. After this change is
merged, the `bun install` command will result in incompatible package versions.
Consequently, the `test:coverage` script, which runs `vitest run --coverage` in the CI
pipeline, will fail at runtime. Vitest enforces version matching between its core and
plugin packages across major versions, so invoking the v2 coverage provider with the v4
core will cause the CI build to fail.

Did we get this right? 👍 / 👎 to inform future reviews.

"@eslint/js": "^9.39.1",
"globals": "^16.5.0",
"typescript-eslint": "^8.46.1"
Expand Down
Loading