Feature: Set up CI Pipeline #97 - #100
Merged
Merged
Conversation
…eads Node version from .nvmrc instead of hardcoding it, keeping local and CI environments in sync from one file.
- Add .github/workflows/ci.yml: lint (non-blocking), unit tests, build - Run on push (except main) and PRs targeting main - Add uniplanWeb/.nvmrc as single source of truth for Node version - Require build-and-test as a required PR status check (branch protection) Lint: - Migrated constructor DI to inject() across all flagged components/services - Removed unused imports/params - Typed faculty-service.ts responses (void, per backend contract) - Left major-service.ts `any` types as warnings — fix tracked in ##99, blocked on in-progress backend facade migrations - Disabled prefer-on-push-component-change-detection for now (perf refactor, out of scope)
- Trigger only on pull_request (opened/synchronize/reopened) instead of push+pull_request, so pushing to a PR branch no longer runs the pipeline twice; covers forks too - Add concurrency group to cancel superseded runs on the same PR/branch - Bump actions/checkout and actions/setup-node to v5 (Node 20 runtime deprecation warning) - Add timeout-minutes: 10 to stop a hung job from running indefinitely - Write coverage % and initial bundle size to the job summary - Skip the pipeline on docs-only PRs (**.md, .claude/**)
- Drop initial bundle size section - Add full lint output (per-file rule violations + problem count) to the job summary so warnings/errors are visible without opening logs
DjesikaV
previously approved these changes
Jul 6, 2026
DjesikaV
left a comment
DjesikaV
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me. I verified the CI commands locally
PIPetkova19
previously approved these changes
Jul 7, 2026
isivanoff
reviewed
Jul 14, 2026
…d it, fixed all the methods with no return type so eslint runs with 0 errors.
isivanoff
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI:
Lint:
anytypes as warnings fix tracked in #Bug: resolve no-explicit-any warnings after facade migrations merge #99, blocked on in-progress backend facade migrations