Skip to content

feature/58-Implement-Settings-Page#101

Open
Manastirski wants to merge 8 commits into
mainfrom
feature/58-Implement-Settings-Page
Open

feature/58-Implement-Settings-Page#101
Manastirski wants to merge 8 commits into
mainfrom
feature/58-Implement-Settings-Page

Conversation

@Manastirski

@Manastirski Manastirski commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

New /settings route: read-only profile card (student today, lector data shapes scaffolded for future role-based auth) plus a bg/en
language switcher

  • Fix app shell layout: remove stray global CSS that squeezed every page into an offcenter column, and make the mobile nav sidebar actually responsive (opens/closes correctly, hamburger stays reachable, closes on outside tap or nav-link click)
  • Fix language preference only being restored on the Settings page it is now applied once at app bootstrap so it persists across reloads and every route

   data shapes scaffolded for future role-based auth) plus a bg/en
   language switcher
 - Fix app shell layout: remove stray global CSS that squeezed every
   page into an off-center column, and make the mobile nav sidebar
   actually responsive (opens/closes correctly, hamburger stays
   reachable, closes on outside tap or nav-link click)
 - Fix language preference only being restored on the Settings page —
   it's now applied once at app bootstrap so it persists across
   reloads and every route
@Manastirski
Manastirski requested a review from a team as a code owner July 13, 2026 12:39
PIPetkova19
PIPetkova19 previously approved these changes Jul 13, 2026
Comment thread uniplanWeb/src/app/core/shared/navmenu-component/navmenu-component.ts Outdated
Comment thread uniplanWeb/src/app/core/shared/navmenu-component/navmenu-component.html Outdated
Comment thread uniplanWeb/src/app/features/settings/settings-service.ts Outdated
PIPetkova19
PIPetkova19 previously approved these changes Jul 20, 2026
Comment thread uniplanWeb/src/app/core/interfaces/lector-profile-elm.ts Outdated
Comment thread uniplanWeb/src/app/core/interfaces/student-profile-elm.ts Outdated
Updated the new convention in Claude.md.
Updated the new convention in .claude/rules/frontend.md
PIPetkova19
PIPetkova19 previously approved these changes Jul 23, 2026
<div>
<app-room-options></app-room-options>
<app-room-table></app-room-table>
<div class="component-panel room">

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you remove app-room-options?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants