refactor: make forms reactive#26
Open
constantine0621 wants to merge 10 commits into
Open
Conversation
added 5 commits
June 16, 2026 18:29
…etectionStrategy, made Reactive form for faculty-add-form
… use Reactive forms
PIPetkova19
reviewed
Jun 17, 2026
| } | ||
|
|
||
| private initForm(): void{ | ||
| this.majorForm = this.formBuilder.group({ |
Contributor
There was a problem hiding this comment.
I think its better to use this this.formBuilder.nonNullable.group instead of majorForm!
Contributor
Author
There was a problem hiding this comment.
I will add .nonNullable so that if .reset() with no arguments is ever called in the future the values won't be reset to null. majorForm! is valid because the form is initialized in ngOnInit before it is used elsewhere. I'll add the .nonNullable fix to all forms.
DjesikaV
previously approved these changes
Jun 22, 2026
DjesikaV
left a comment
DjesikaV
left a comment
Contributor
There was a problem hiding this comment.
Looks good overall. ngModel is removed, the forms are using Reactive Forms now, and the add/edit dialogs open as expected.
…o Make-forms-reactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored the old forms in faculty, major, student, now using Reactive forms.
At the start I had a problem with ChangeDetectionStrategy.Eager not existing, fixed it by deleting and remaking tsconfig.json and node_modules.