Enhancement/38 use dropdowns for major course type in student add form#73
Open
DjesikaV wants to merge 7 commits into
Open
Enhancement/38 use dropdowns for major course type in student add form#73DjesikaV wants to merge 7 commits into
DjesikaV wants to merge 7 commits into
Conversation
Contributor
Author
|
Commits for access modifiers and student editing are also shown here because I created this branch on top of another feature branch instead of creating it directly from main. |
…e-Type-in-student-add-form
PIPetkova19
requested changes
Jul 7, 2026
| }) | ||
| export class AddForm { | ||
| @Input() title: string = ''; | ||
| @Input() public title: string = ''; |
Contributor
There was a problem hiding this comment.
Use newer syntax->input signal
| @Input() public title: string = ''; | ||
|
|
||
| @Output() saveClicked = new EventEmitter<void>(); | ||
| @Output() public readonly saveClicked :EventEmitter<void> = new EventEmitter<void>(); |
| private viewService: ViewService, | ||
| private majorService: MajorService, | ||
| private facultyService: FacultyService | ||
| ) { |
Contributor
There was a problem hiding this comment.
Main panel doesn't exist anymore
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added dropdown fields to the student add form.
Changes:
MajorOptionElminterface for the/api/majorsbackend response.MajorService.