feature/51-added fully working lector view#81
Open
DrDeathDrop wants to merge 10 commits into
Open
Conversation
DrDeathDrop
changed the title
PIPetkova19
reviewed
Jun 29, 2026
PIPetkova19
left a comment
PIPetkova19
left a comment
Contributor
There was a problem hiding this comment.
In addition to my comments, fix the margin
added 4 commits
June 30, 2026 14:12
# Conflicts: # uniplanWeb/src/app/core/shared/main-panel/main-panel.html # uniplanWeb/src/app/core/shared/main-panel/main-panel.ts # uniplanWeb/src/app/core/shared/navmenu-component/navmenu-component.html # uniplanWeb/src/app/core/shared/navmenu-component/navmenu-component.ts
…pes, added translate pipes to hardcoded alerts
DrDeathDrop
force-pushed
the
feature/51-implement-teacher-view-functionality
branch
from
June 30, 2026 11:50
f86650f to
b6f788e
Compare
Replace hardcoded localhost URLs in LectorService with API_ENDPOINTS.lectors, point the lector-panel spec's URL constants at the shared endpoints, and fix the spec to invoke the table's signal inputs.
DrDeathDrop
force-pushed
the
feature/51-implement-teacher-view-functionality
branch
from
June 30, 2026 11:53
b6f788e to
d4246a3
Compare
PIPetkova19
requested changes
Jul 7, 2026
PIPetkova19
left a comment
PIPetkova19
left a comment
Contributor
There was a problem hiding this comment.
Edit faculty doesn't work
Contributor
Author
Refer to the first comment i have posted |
PIPetkova19
approved these changes
Jul 7, 2026
Manastirski
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A bug persists where if we edit a lector and we want to change the faculty - then the edit won't work. The cause is in the backend, and the fix is in a PR.