feature/90-student-database-connection#91
Open
constantine0621 wants to merge 24 commits into
Open
Conversation
…e StudentTable to load students dynamically
…use majorName, majorType, courseType, and courseSubtype
…include courseYear and replace majorType with courseType
…ta retrieval feat(student): integrate MatDialog in StudentTable for dialog management
…and faculty features refactor(student): remove deprecated student warnings file
…glish localization files
…o Feature--Student-db-connection
…o Feature--Student-db-connection
…URL, fixed wrong URL in CourseService
…ni-dev-lab/uniplan-web into Feature--Student-db-connection
PIPetkova19
reviewed
Jul 8, 2026
PIPetkova19
left a comment
PIPetkova19
left a comment
Contributor
There was a problem hiding this comment.
Data isn't correctly visualized and I also added comments before, which are still not resolved 
| majorId: string; | ||
| majorName: string; | ||
| courseType: string; | ||
| courseSubtype: 'редовно' | 'задочно'; |
Manastirski
reviewed
Jul 8, 2026
| ) | ||
| ); | ||
| } | ||
| createStudent(student: Omit<StudentElm, 'position' | 'id'>): Observable<any> { |
Contributor
There was a problem hiding this comment.
Observable is not a good idea, not only here but in general.
Contributor
Author
There was a problem hiding this comment.
If the CRUD service methods should return a type that is not Observable it should be a separate refactoring issue and PR, since Observable is used in all the domains.
…udent service methods to return void
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the Student table loads hardcoded mock data. This PR replaces that static data by fetching from the database.
i18n is implemented.
Changes to StudentElm, it now has all the necessary attributes.
Changes to StudentTable.
Added StudentService.
Added CourseElm, as well as CourseService which are needed for Add and Edit forms' dropdowns.