bug/116-fixed edit faculty not working on lector#117
Open
DrDeathDrop wants to merge 1 commit into
Open
Conversation
DrDeathDrop
changed the title
PIPetkova19
reviewed
Jun 25, 2026
| public LectorDto createLector(LectorDto lectorDto) { | ||
| final Lector lector = lectorMapper.toEntity(lectorDto); | ||
|
|
||
| if (lectorDto.facultyId() != null) { |
Contributor
There was a problem hiding this comment.
Internal dtos will not be used.
PIPetkova19
reviewed
Jun 25, 2026
| } | ||
|
|
||
| @Test | ||
| void testCreateLectorShouldSetFacultyWhenFacultyIdIsNotNull() { |
Contributor
There was a problem hiding this comment.
Change naming convention. For example "findById_shouldReturnEntity_whenFacultyExists"
PIPetkova19
reviewed
Jun 25, 2026
| private LectorDto updateEntityAndConvertToDto(final LectorDto dto, | ||
| final Lector entity) { | ||
| final Lector entity) { | ||
| lectorMapper.updateEntityFromDto(dto, entity); |
Contributor
There was a problem hiding this comment.
Mapping should be in the facade layer.
PIPetkova19
requested changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.