Facade migration t1 migrate roomcategory to facade pattern#122
Open
DjesikaV wants to merge 8 commits into
Hidden character warning
The head ref may contain hidden characters: "Facade-migration\u2014T1-Migrate-roomcategory-to-Facade-pattern"
Open
Facade migration t1 migrate roomcategory to facade pattern#122DjesikaV wants to merge 8 commits into
DjesikaV wants to merge 8 commits into
Conversation
PIPetkova19
reviewed
Jun 30, 2026
PIPetkova19
left a comment
PIPetkova19
left a comment
Contributor
There was a problem hiding this comment.
Add messages to dto validators
PIPetkova19
reviewed
Jun 30, 2026
| public record RoomCategoryResponseDto( | ||
|
|
||
| @NotNull | ||
| @NotNull(message = "Room ID cannot be null") |
Contributor
There was a problem hiding this comment.
I think the response dto shouldn't have validators
Manastirski
previously approved these changes
Jun 30, 2026
DjesikaV
changed the title
PIPetkova19
previously approved these changes
Jun 30, 2026
s100ian
previously approved these changes
Jun 30, 2026
constantine0621
left a comment
constantine0621
left a comment
Contributor
There was a problem hiding this comment.
Make tests for Validator and Mapper
PIPetkova19
reviewed
Jul 7, 2026
PIPetkova19
left a comment
PIPetkova19
left a comment
Contributor
There was a problem hiding this comment.
Naming convention for test method names is
->findById_shouldReturnEntity_whenFacultyExists;
Add tests for mapper
Contributor
|
@DjesikaV please, respond to the comments. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes: