Bug: Edit for Student (#109)#126
Open
constantine0621 wants to merge 33 commits into
Open
Conversation
…ade, made changes to StudentMapper, updated StudentServiceTest and created tests for new classes
…ent-db-connection # Conflicts: # src/main/java/org/unilab/uniplan/student/StudentController.java # src/main/java/org/unilab/uniplan/student/StudentMapper.java # src/main/java/org/unilab/uniplan/student/StudentService.java # src/test/java/org/unilab/uniplan/student/StudentServiceTest.java
…ent-db-connection
…Facade layer, added NotBlank validation to RequestDto and switched out Service repository calls
…Student # Conflicts: # src/main/java/org/unilab/uniplan/student/StudentController.java # src/main/java/org/unilab/uniplan/student/StudentService.java
…ent-db-connection
…validation on controller @PathVariable parameters
…ent-db-connection # Conflicts: # src/main/java/org/unilab/uniplan/student/StudentRepository.java # src/main/java/org/unilab/uniplan/student/dto/StudentCourseMajorDto.java # src/main/java/org/unilab/uniplan/student/dto/StudentResponseDto.java
…questDto instead of Student entity, adjusted tests and changed test names to adhere to convention
…ent-db-connection # Conflicts: # src/test/java/org/unilab/uniplan/student/StudentServiceTest.java
…ent-db-connection
…Student # Conflicts: # src/main/java/org/unilab/uniplan/student/StudentWebFacade.java
DjesikaV
reviewed
Jul 16, 2026
DjesikaV
requested changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes to update logic. Added getReference to CourseService to correctly update Student's Course. This branch is branched off of Feature--Student-db-connection, best to go through PR #123 first.