84 facade migration t3 course#131
Open
DjesikaV wants to merge 6 commits into
Open
Conversation
added 6 commits
July 17, 2026 10:33
Manastirski
requested changes
Jul 18, 2026
| @GetMapping("/major/{majorId}") | ||
| public List<CourseResponseDto> getCoursesByMajorId(@PathVariable @NotNull final UUID majorId) { | ||
| return courseMapper.toResponseDtoList(courseService.findAllByMajorId(majorId)); | ||
| public ResponseEntity<List<CourseResponseDto>> getCoursesByMajorId(@PathVariable @NotNull final UUID majorId) { |
| @GetMapping("/{id}") | ||
| public ResponseEntity<CourseResponseDto> getMajorById(@PathVariable @NotNull final UUID id) { | ||
| return ResponseEntity.ok(courseMapper.toResponseDto(courseService.findCourseById(id))); | ||
| public ResponseEntity<CourseResponseDto> getCourseById(@PathVariable @NotNull final UUID id) { |
Contributor
There was a problem hiding this comment.
path variables cannot be null by default, remove the @Not null annotation in all the places where its not needed.
Comment on lines
+18
to
+24
| public void validateForCreate(final CourseRequestDto requestDto) { | ||
| validateMajorExists(requestDto.majorId()); | ||
| } | ||
|
|
||
| public void validateForUpdate(final CourseRequestDto requestDto) { | ||
| validateMajorExists(requestDto.majorId()); | ||
| } |
Contributor
There was a problem hiding this comment.
Since the validation logic for creation and updating is currently identical, we could combine them into a single method. DRY principle.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes: