Jira migration/95 optimize resourse not found exception - #132
Open
PIPetkova19 wants to merge 4 commits into
Open
Jira migration/95 optimize resourse not found exception#132PIPetkova19 wants to merge 4 commits into
PIPetkova19 wants to merge 4 commits into
Conversation
Manastirski
requested changes
Jul 23, 2026
Manastirski
left a comment
Manastirski
left a comment
Contributor
There was a problem hiding this comment.
There is no i18n for the exception messages and they will be shown in English to the clients, consider adding i18n.
| @@ -26,13 +26,12 @@ public class GlobalExceptionHandler { | |||
| //Handles resource not found exceptions triggered by element not found by search parameters | |||
| @ExceptionHandler(ResourceNotFoundException.class) | |||
| public ResponseEntity<ErrorResponse> handleValidationException(final ResourceNotFoundException ex, | |||
Contributor
There was a problem hiding this comment.
this method handles resource not found exception, but its called handleValidationException
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes made: