Conversation
📝 WalkthroughWalkthroughThis PR upgrades the monorepo to Vite 8.0.14 while maintaining backward compatibility with Vite 7, fixes a Lightning CSS serialization issue with null values in class rules, and updates dependencies including Tailwind CSS to 4.3.0. It also migrates e2e test bundling from esbuild to Bun. ChangesVite 8 Compatibility and Lightning CSS Fixes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/uniwind/tests/e2e/global-setup.ts`:
- Around line 38-51: Bun.build currently throws on failure so the if
(!bundle.success) branch is never reached; update the call to Bun.build (used in
the test setup around entryPath/GENERATED_DIR) to use throw: false (or wrap the
Bun.build call in try/catch) so a failed build returns a bundle object with
bundle.success === false and you can format and throw
bundle.logs.map(...).join('\n') as intended; ensure you reference bundle.success
and bundle.logs in the failure path (or handle the caught error to produce the
same formatted message).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: a097ce5f-6a20-4d4e-9a73-cf35c32f9dd6
⛔ Files ignored due to path filters (1)
bun.lockis excluded by!**/*.lock
📒 Files selected for processing (6)
apps/vite-example/package.jsonpackage.jsonpackages/uniwind/package.jsonpackages/uniwind/src/bundler/adapters/vite/vite.tspackages/uniwind/src/bundler/css-visitor/rule-visitor.tspackages/uniwind/tests/e2e/global-setup.ts
|
🚀 This pull request is included in v1.8.0. See Release v1.8.0 for release notes. |
fixes #554
Summary by CodeRabbit
Chores
Bug Fixes
New Features