Skip to content

fix: phantom dependencies#561

Merged
Brentlok merged 1 commit into
mainfrom
fix/phantom-dependencies
Jun 1, 2026
Merged

fix: phantom dependencies#561
Brentlok merged 1 commit into
mainfrom
fix/phantom-dependencies

Conversation

@Brentlok

@Brentlok Brentlok commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

fix #552

Summary by CodeRabbit

  • Chores
    • Updated peer dependency requirements for Metro and React Native tooling packages to ensure compatibility across broader configuration scenarios.
    • Designated select peer dependencies as optional to provide greater flexibility during installation and setup.

@coderabbitai

coderabbitai Bot commented Jun 1, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 7cbcb4ef-b9a5-4f9b-9d5f-357c5599e6d4

📥 Commits

Reviewing files that changed from the base of the PR and between 1cad2cb and 0f8f296.

⛔ Files ignored due to path filters (1)
  • bun.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • packages/uniwind/package.json

📝 Walkthrough

Walkthrough

The uniwind package expands its peer dependency requirements to include Metro and React Native tooling packages (metro, metro-cache, @expo/metro-config, metro-transform-worker), marking two of them as optional peers.

Changes

Metro peer dependency declaration

Layer / File(s) Summary
Metro peer dependencies and optional markers
packages/uniwind/package.json
Updated peerDependencies to add Metro and related React Native tooling (metro, metro-cache, @expo/metro-config, metro-transform-worker) alongside existing Tailwind peer. Added peerDependenciesMeta to mark @expo/metro-config and metro-transform-worker as optional peer dependencies.

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • uni-stack/uniwind#376: Removes ./metro MJS export from the same package.json, directly related to this Metro configuration surface change.

Suggested reviewers

  • jpudysz

Poem

🐰 A rabbit declares its Metro-trusted friends,
With caches and transforms—oh, how it extends!
Some optional, some required, a careful peer dance,
To fix broken imports in Expo's expanse!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Linked Issues check ⚠️ Warning The PR adds peer dependencies for metro tooling packages but does not implement the suggested coding changes to fix the private path issue in the metro plugin. Update the metro plugin code to use @expo/metro-config/file-store for Expo projects and fall back to metro-cache for bare React Native, as specified in issue #552.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix: phantom dependencies' clearly identifies the main change—addressing phantom dependencies in the uniwind package.
Out of Scope Changes check ✅ Passed All changes to package.json peer dependencies are within scope for addressing phantom dependency resolution issues referenced in issue #552.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/phantom-dependencies

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Brentlok Brentlok merged commit f73c9e7 into main Jun 1, 2026
2 checks passed
@Brentlok Brentlok deleted the fix/phantom-dependencies branch June 1, 2026 10:56
@github-actions

github-actions Bot commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

🚀 This pull request is included in v1.8.0. See Release v1.8.0 for release notes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Metro plugin imports private metro-cache path; breaks under isolated installs and Expo (vendored metro)

1 participant