Open
Conversation
jedevc
force-pushed
the
jedevc/shortcut-flags
branch
5 times, most recently
from
e81f756 to
302f515
Compare
jedevc
force-pushed
the
jedevc/shortcut-flags
branch
from
302f515 to
e3813f5
Compare
jedevc
force-pushed
the
jedevc/shortcut-flags
branch
from
e3813f5 to
0fda2a8
Compare
jedevc
force-pushed
the
jedevc/shortcut-flags
branch
from
0fda2a8 to
1e0fc5d
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 28 out of 28 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jedevc
force-pushed
the
jedevc/shortcut-flags
branch
from
1e0fc5d to
7f6adf2
Compare
jedevc
changed the title
jedevc
force-pushed
the
jedevc/shortcut-flags
branch
from
7f6adf2 to
e3d9848
Compare
For `create` and `edit` commands, we can easily support some shortcut flags. Signed-off-by: Justin Chadwell <justin@unikraft.com>
jedevc
force-pushed
the
jedevc/shortcut-flags
branch
from
e3d9848 to
0d901de
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For
createandeditcommands, we can easily support some shortcut flags.There is one major breaking change -
unikraft runnow takes an explicit--imageflag, instead of an arg, which is so thatrunandinstance createare essentially the same underlying code.