Ignore invalid item transform types on item models#83
Open
rtm516 wants to merge 1 commit intounnamed:mainfrom
Open
Ignore invalid item transform types on item models#83rtm516 wants to merge 1 commit intounnamed:mainfrom
rtm516 wants to merge 1 commit intounnamed:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an issue where an error would be thrown when processing an item model with a non-standard item transform type. The vanilla client ignores any invalid types.
Example: https://github.com/Graclyxz/Many-More-Ores-and-Crafts/blob/941837076ee80e0e616e74330508d496ca10b10a/common/src/main/resources/assets/many_more_ores_and_crafts/models/item/tin_ore.json
This will cause the
valueOfcall to fail asthirdpersonisn't a valid option. Following this change it will safely ignore the exception thrown and allow parsing to continue.