Compresion#6
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added compression option to ShadowCat. This has some breaking changes for old code, notably that there is now a 'flags' field, which tells the receiver if the file is compressed. However, this futureproofs the protocol for adding more features/ideas later! Break early, I guess... 😅
Anyway, compression is now optional; if checked, the file is compressed and compared to its original length. If it adds length, the compression is skipped. Else, the compressed version of the file is sent, but the CRC check is for the original file. So, if compressed, the receiver uncompresses it and reads the output, else it just parses the output.
Tests, tools, and docs updated.