Skip to content

fix: notification display and functionality + nuxtui refactor #1860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ajit-Mehrotra wants to merge 96 commits into
base: main
Choose a base branch
from

perf(web): make notification settings fetch non-blocking during mount

338f928
Select commit
Loading
Failed to load commit list.
Open

fix: notification display and functionality + nuxtui refactor #1860

perf(web): make notification settings fetch non-blocking during mount
338f928
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 13, 2026 in 1s

47.07% (+0.57%) compared to 9ef1cf1

View this Pull Request on Codecov

47.07% (+0.57%) compared to 9ef1cf1

Details

Codecov Report

❌ Patch coverage is 76.25571% with 416 lines in your changes missing coverage. Please review.
✅ Project coverage is 47.07%. Comparing base (9ef1cf1) to head (338f928).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
...h/resolvers/notifications/notifications.service.ts 77.64% 57 Missing ⚠️
...Notifications/CriticalNotifications.standalone.vue 0.00% 42 Missing ⚠️
web/src/helpers/functions.ts 8.57% 32 Missing ⚠️
...difier/modifications/notify-script.modification.ts 77.47% 25 Missing ⚠️
...ier/modifications/default-base-css.modification.ts 61.29% 24 Missing ⚠️
web/src/components/Wrapper/mount-engine.ts 53.65% 19 Missing ⚠️
...er/modifications/default-white-css.modification.ts 64.44% 16 Missing ⚠️
...le-modifier/modifications/helptext.modification.ts 68.00% 16 Missing ⚠️
...er/modifications/default-azure-css.modification.ts 61.53% 15 Missing ⚠️
...er/modifications/default-black-css.modification.ts 61.53% 15 Missing ⚠️
... and 24 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1860      +/-   ##
==========================================
+ Coverage   46.49%   47.07%   +0.57%     
==========================================
  Files         954      965      +11     
  Lines       59788    61002    +1214     
  Branches     5552     5651      +99     
==========================================
+ Hits        27799    28715     +916     
- Misses      31870    32171     +301     
+ Partials      119      116       -3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov