Update note on disk removal GUI requirements #403
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clarified that in current releases, the GUI only supports removing disks in RAID 1 configuration. If you do it with other redundant btrfs profiles, it will leave the pool degraded instead.
Contributor
📝 WalkthroughWalkthroughDocumentation was updated to clarify that the GUI for removing disks in Unraid requires the pool to be configured with RAID 1 for both data and metadata on BTRFS, replacing the previous generic note about redundant RAID profiles. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In @docs/unraid-os/using-unraid-to/manage-storage/partials/remove-disk-gui.mdx:
- Line 4: Update the sentence that currently reads "The GUI currently only
supports removing devices if your pool is set up for %%RAID 1|raid1%% (for both
data and metadata for %%BTRFS|btrfs%%)" to (1) add the missing warning that
attempting disk removal via the GUI on pools using other redundant btrfs
profiles will leave the pool degraded, and (2) explicitly state the behavior for
ZFS pools (whether the RAID 1 requirement applies or if ZFS has different
support/limitations). Locate the sentence in remove-disk-gui.mdx and append a
clear warning sentence referencing non-RAID1 btrfs profiles leaving the pool
degraded, then add a short clarification line specifying the equivalent
requirement or difference for ZFS pools (e.g., "For ZFS, ...") so readers know
the exact support and risk.
📜 Review details
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs/unraid-os/using-unraid-to/manage-storage/partials/remove-disk-gui.mdx
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: deploy-preview
docs/unraid-os/using-unraid-to/manage-storage/partials/remove-disk-gui.mdx
Show resolved
Hide resolved
Contributor
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarified that in current releases, the GUI only supports removing disks in RAID 1 configuration. If you do it with other redundant btrfs profiles, it will leave the pool degraded instead.
Before Submitting This PR, Please Ensure You Have Completed The Following:
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.