Skip to content

Высокий Лев#37

Open
vysokiylev wants to merge 2 commits intourfu-2017:masterfrom
vysokiylev:master
Open

Высокий Лев#37
vysokiylev wants to merge 2 commits intourfu-2017:masterfrom
vysokiylev:master

Conversation

@vysokiylev
Copy link
Copy Markdown

@vysokiylev vysokiylev commented Oct 13, 2017

@honest-hrundel
Copy link
Copy Markdown

🍅 Не пройден линтинг или базовые тесты

@honest-hrundel
Copy link
Copy Markdown

🍏 Пройден линтинг и базовые тесты

Copy link
Copy Markdown

@v3new v3new left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Необходимо как минимум исправить задачи с томатом 🍅

Comment thread tasks/10.html
<style>
/* your styles here */

.global-scope > .title:first-letter
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Повышение специфичности при помощи .global-scope излишне,
касается также и всех последующих задач

Comment thread tasks/12.html
<style>
/* your styles here */

div:nth-child(odd)
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Неплохо, но советую обратить внимание на псевдокласс :empty

Comment thread tasks/13.html
<style>
/* your styles here */

div:nth-child(4n + 1) > div:first-child
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Неплохо, но почитай про :only-of-type

Comment thread tasks/15.html
<style>
/* your styles here */

li > a[href$='.zip']:after
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Зачем тут li > ? Где-то ещё есть ссылки?

Comment thread tasks/16.html
<main class="global-results">
<style>
/* your styles here */

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Тут сразу нет, не совпадает с эталоном 🍅

Comment thread tasks/20.html
<style>
/* your styles here */

.red-gt2:nth-child(n+3) div
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Задача должна работать динамически, даже если изменить кол-во блоков случайно внутри 🍅

Comment thread tasks/4.html
/* your styles here */
</style>

.global-scope > article
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Обрати внимание на селектор +

Comment thread tasks/5.html
<style>
/* your styles here */

.global-scope > input:checked ~ div
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.global-scope тут лишний

Comment thread tasks/6.html
<style>
/* your styles here */

.global-scope > a:first-child
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Попробуй решить при помощи селектора атрибутов

Comment thread tasks/9.html
<style>
/* your styles here */

.global-scope a:first-child:hover
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Задача решена неверно - ссылки не меняют состояние при нажатии 🍅

@v3new
Copy link
Copy Markdown

v3new commented Oct 29, 2017

Я поздно приступил к проверке задания, попрошу, чтобы за это не снижали балл

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants