fix(git): handle SSH remote URLs with explicit ports#286
Merged
sachiniyer merged 1 commit intomainfrom May 9, 2026
Merged
Conversation
Repo auto-inference returned None for valid SSH URLs that include an explicit port in the authority (e.g. ssh://git@github.com:22/owner/repo.git) because strict prefix matching only accepted ssh://git@github.com/. Add a strip_ssh_port normalization step that mirrors the existing HTTP-credentials normalization, so SSH URLs with ports fall through to the existing prefix match. Closes #272. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
sachiniyer
temporarily deployed
to
integration-tests
GitHub Actions
Inactive
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
parse_github_remote_urlrejected valid SSH remotes with explicit ports (e.g.ssh://git@github.com:22/owner/repo.git) because the prefix list only matchedssh://git@github.com/, breaking repo auto-inference for users with that remote format.strip_ssh_portnormalization helper (mirroring the existingstrip_http_credentialspattern) that drops:PORTfrom the SSH authority before prefix matching, so the URL falls through to the existing path.:22, a non-default port, port + no.gitsuffix, port + trailing slash, and rejection of ports on non-GitHub hosts.Closes #272.
Test plan
cargo test --lib utils::git— 25 passed (5 new, 20 existing)cargo test— full suite greencargo fmt --checkcargo clippy --lib🤖 Generated with Claude Code