Implement build/deploy log support #490
Open
+190
−13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds support for build and task logs and relies on uselagoon/lagoon-ssh-portal#570.
The
logscommand gets two new flags. The idea is that you can specify--taskto get logs from all running tasks, or--task=nameif you know the name.The
deploysubcommands also gets new flags--followthat stream deploy logs until the deployment completes.I have no idea if this is a good developer UX: feedback requested.
I have tested this manually using the
deploy latestsubcommand, but have not actually tested the other subcommands because I don't have a good test environment for them. Please let me know if they are broken! In particular, the code relies on theresultData.Resultbeing the name of the build. This holds fordeploy latest, but I don't know if it holds for other subcommands?