Fix/checkbox indexing codeblock #5321
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spaghetti-coder
suggested changes
Dec 6, 2025
Contributor
spaghetti-coder
left a comment
spaghetti-coder
left a comment
There was a problem hiding this comment.
Thanks for the quick reaction, but found some issues with the solution.
| export function isInsideCodeBlock(lines :string [] , index : number):boolean{ | ||
| let inside = false; | ||
| for(let i = 0 ; i <= index ; i++){ | ||
| if(lines[i].startsWith("```")){ |
Contributor
There was a problem hiding this comment.
It doesn't trap the following cases:
- When codeblock is embraced with
~~~instead of``` - When the codeblock has let's say 2 spaces offset:
The codeblock has 2 spaces offset
```
- [ ] foo
```
- [ ] bar
- The following one will still make
foochecked:
````
``` <- This will be rendered as a triple back quote inside the code block
- [ ] foo
````
- [ ] bar
| let currentTaskIndex = 0; | ||
|
|
||
| for (let i = 0; i < lines.length; i++) { | ||
| if (isInsideCodeBlock(lines, i)) continue; |
Contributor
There was a problem hiding this comment.
It will unnecessarily slow down the execution. Better put the check inside the match block
| return lines.join("\n"); | ||
| } | ||
|
|
||
| export function isInsideCodeBlock(lines :string [] , index : number):boolean{ |
Contributor
There was a problem hiding this comment.
The function only covers very straight scenarios. A sample when it fails
<!--
Some comments
```
More comments
-->
```
The function thinks this line is not in a codeblock
```
Contributor
Author
There was a problem hiding this comment.
sorry sir for inconvenience i will fix it please give me some time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: Incorrect checkbox toggling when preceded by a codeblock checkbox
This PR fixes Issue #5319, where toggling a checkbox in view mode updates the wrong task if a checkbox inside a fenced code block appears earlier in the note.
What’s fixed
A demo video is attached showing the bug and the expected behavior.
vid.mp4