Fixed nearly all remaining type errors #950
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
STILL TODO:
1. error("Types Maybe[&T \<: Tree] and Maybe[&A]::just(&A val) do not match",|file:///Users/paulklint/git/rascal-language-servers/rascal-lsp/src/main/rascal/lsp/lang/rascal/lsp/refactor/rename/Common.rsc|(3468,4,<86,4>,<86,8>),fixes=[],causes=[])
[This could be an error in type instantiation in the type checker]
2. error("Cannot call `changed` with keyword arguments ``needsConfirmation` of type `bool``, ``description` of type `str`` and ``label` of type `str``, given definitions `FileSystemChange(list[TextEdit]), FileSystemChange::changed(loc file, list[TextEdit] edits) or FileSystemChange::changed(loc file)`",|file:///Users/paulklint/git/rascal-language-servers/rascal-lsp/src/main/rascal/lsp/lang/rascal/lsp/Templates.rsc|(2198,122,<55,25>,<55,147>),fixes=[],causes=[])
[Simple error]
3. error("No definition found for anno, keywordfield or field `top` in type `Module`",|file:///Users/paulklint/git/rascal-language-servers/rascal-lsp/src/main/rascal/lsp/lang/rascal/lsp/Templates.rsc|(2499,3,<58,44>,<58,47>),fixes=[],causes=[])
[Unclear]
4. error("Return type `int` expected, found `num`",|file:///Users/paulklint/git/rascal-language-servers/rascal-lsp/src/main/rascal/lsp/lang/rascal/tests/rename/Benchmark.rsc|(4637,56,<72,15>,<72,71>),fixes=[],causes=[])
[Simple error]
- Rename missed overload. - Fix `moduleStatus` constructor call. - Fix typo in variable name.
Member
On line 59 of Sounds like usethesource/rascal#2496. A work-around is to explicitly type |
toinehartman
approved these changes
Jan 21, 2026
rascal-lsp/src/main/rascal/lsp/lang/rascal/lsp/refactor/Rename.rsc
Outdated
Show resolved
Hide resolved
….rsc Removed space Co-authored-by: Toine Hartman <toinehartman@users.noreply.github.com>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
STILL TODO:
error("Types Maybe[&T <: Tree] and Maybe[&A]::just(&A val) do not match",|file:///Users/paulklint/git/rascal-language-servers/rascal-lsp/src/main/rascal/lsp/lang/rascal/lsp/refactor/rename/Common.rsc|(3468,4,<86,4>,<86,8>),fixes=[],causes=[])
[This could be an error in type instantiation in the type checker]
error("Cannot call
changedwith keyword argumentsneedsConfirmation` of type `bool,description` of type `strandlabel` of type `str, given definitionsFileSystemChange(list[TextEdit]), FileSystemChange::changed(loc file, list[TextEdit] edits) or FileSystemChange::changed(loc file)",|file:///Users/paulklint/git/rascal-language-servers/rascal-lsp/src/main/rascal/lsp/lang/rascal/lsp/Templates.rsc|(2198,122,<55,25>,<55,147>),fixes=[],causes=[])[Simple error]
error("No definition found for anno, keywordfield or field
topin typeModule",|file:///Users/paulklint/git/rascal-language-servers/rascal-lsp/src/main/rascal/lsp/lang/rascal/lsp/Templates.rsc|(2499,3,<58,44>,<58,47>),fixes=[],causes=[])[Unclear]
error("Return type
intexpected, foundnum",|file:///Users/paulklint/git/rascal-language-servers/rascal-lsp/src/main/rascal/lsp/lang/rascal/tests/rename/Benchmark.rsc|(4637,56,<72,15>,<72,71>),fixes=[],causes=[])[Simple error]