feat/refactor-roles#48
Open
r0liveir wants to merge 6 commits into
Open
Conversation
This commit introduces SessionRole, SessionActor and passes Delegation as a subobject of SessionActor, which is a model defining who is acting right now. It also changes and makes every call to know who send the event to use SessionActor now Expected usage in frontend is as: , later usage will strip display_name from here so we can verify only by delegation_id or an introduced mapping (user_id -> delegation_id) setted at OPEN_SESSION stage or by chair
…ActorResolutionError for upstream WebSocket exception handling
Contributor
Author
|
@Extroias @Rafael-Lombardi @milena-depaula deem suas reviews (mesmo que não tenham familiaridade com o frontend) e vejam se faz sentido pro nosso uso atual :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduce SessionActor as an internal model that is used by engine, service, manager, and etc.
It also standardizes every call to either "sender: str" or "delegation_id: int" into something more useful.
This is part of a broader range of commits aimed to automate testing of API and React