Update Drone_sensor_library.ino - WSchuler #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addition of comments and questions to the code. Marked by WSchuler
zbkitz
requested changes
Jan 18, 2024
Collaborator
zbkitz
left a comment
zbkitz
left a comment
There was a problem hiding this comment.
Thanks for fixing the comments on the messages and publishers.
In lines 161 and 231, each case is a different "mode" for the system; each case is already labeled with the name of the corresponding mode in the line above each case statement (e.g. lines 162 and 232). Are you asking me to add a summary of the function of each mode?
I'm going to hold off on merging until you've had a chance to review the rest of the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addition of comments and questions to the code. Marked by WSchuler