-
-
Notifications
You must be signed in to change notification settings - Fork 384
Hide platform-hidden Steam and GOG games from the library #1796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
whatobiplays
wants to merge
14
commits into
utkarshdalal:master
Choose a base branch
from
whatobiplays:obi/hide-hidden-games
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2,770
−20
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
399df45
Hide platform-hidden Steam and GOG games from the library
ec97909
Refresh library immediately when hidden-games setting changes
8009316
Store GOG hidden state in gog_games.hidden column
cece3ed
Fix hidden-game handling review findings
252fb92
Address follow-up hidden-game review findings
e6f37b0
Prevent stale hidden refreshes from overwriting newer ones
96cb36a
Harden hidden-refresh generation and single-game hidden state
3a47076
Preserve hidden state in single-game refresh and fix cancellation flow
2c3e7b3
Preserve GOG cover on upsert and propagate sync cancellation
887e4db
Stamp new GOG rows with the newest committed hidden set
909b3b0
Use only committed hidden set when stamping refreshed GOG rows
f885819
Default hidden games to visible and simplify GOG hidden handling
80cb8fa
Confirm empty GOG hidden response via fallback before clearing flags
a84a733
Preserve primary failure when confirming empty GOG hidden response
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
1,881 changes: 1,881 additions & 0 deletions
1,881
app/schemas/app.gamenative.db.PluviaDatabase/26.json
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| package app.gamenative.data | ||
|
|
||
| import app.gamenative.PrefManager | ||
|
|
||
| /** | ||
| * Visibility rules for games the user has hidden on a platform. | ||
| * | ||
| * Hidden games stay visible by default so an update never makes existing library entries | ||
| * disappear. Turning off the "show hidden games by default" setting excludes them again, and | ||
| * Steam's built-in Hidden collection can still explicitly reveal hidden Steam games. Missing | ||
| * hidden metadata fails open so a game is never hidden just because the metadata has not loaded. | ||
| */ | ||
| object HiddenGameFilter { | ||
| /** | ||
| * Whether a Steam app should appear in the library. | ||
| * | ||
| * @param appId Steam app ID to test. | ||
| * @param hiddenAppIds IDs from the Steam Hidden collection; empty when collections are unloaded. | ||
| * @param showHiddenByDefault Value of [PrefManager.showHiddenGamesByDefault]. | ||
| * @param hiddenCollectionSelected Whether the Hidden collection is among the selected collection IDs. | ||
| */ | ||
| fun passesSteam( | ||
| appId: Int, | ||
| hiddenAppIds: Set<Int>, | ||
| showHiddenByDefault: Boolean, | ||
| hiddenCollectionSelected: Boolean, | ||
| ): Boolean = showHiddenByDefault || hiddenCollectionSelected || appId !in hiddenAppIds | ||
|
|
||
| /** | ||
| * Whether a GOG game should appear in the library. | ||
| * | ||
| * @param isHidden Whether the GOG row is flagged hidden (rows default to false until the first | ||
| * hidden-metadata refresh, which fails open). | ||
| * @param showHiddenByDefault Value of [PrefManager.showHiddenGamesByDefault]. | ||
| */ | ||
| fun passesGog( | ||
| isHidden: Boolean, | ||
| showHiddenByDefault: Boolean, | ||
| ): Boolean = showHiddenByDefault || !isHidden | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.