GH-611: Accountant Overlapping Scans (self review) #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… closure inside tools.rs
…scan, but the scan is already running
…can is already running
… whether a scan is running
… is already running
…Receipts with an empty vector
…tests in accountant/mod.rs
…he scan_finished() of scanners.rs
… of all the Scanners
…finished() stops the scan
…es and deliquencies
…r of nothing to process
…d_monitored_until_it_gets_confirmed_or_canceled()
…to accountant/test_utils.rs
…sts of accountant/mod.rs
utkarshg6
commented
Oct 3, 2022
| &format!( | ||
| "should be called only on uninitialized object, not: ScanIntervals(Some({:?}))", | ||
| *DEFAULT_SCAN_INTERVALS | ||
| make_scan_intervals_with_defaults() |
Owner
Author
There was a problem hiding this comment.
Don't use this function, instead just dereference the DEFAULT_SCAN_INTERVALS.
| when_pending_too_long_sec: DEFAULT_PENDING_TOO_LONG_SEC, | ||
| suppress_initial_scans: false, | ||
| } | ||
| pub fn make_bc_with_defaults() -> BootstrapperConfig { |
Owner
Author
There was a problem hiding this comment.
Try using builder method for building the bootstrap config.
| recorder_message_handler!(AddRouteMessage); | ||
| recorder_message_handler!(AddStreamMsg); | ||
| recorder_message_handler!(BindMessage); | ||
| recorder_message_handler!(ConnectionProgressMessage); |
Owner
Author
There was a problem hiding this comment.
Move this line after recorder_message_handler!(ScanForPayables);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.