Skip to content

Conversation

@hmacr
Copy link
Contributor

@hmacr hmacr commented Jan 6, 2026

Related SER-728

Summary by CodeRabbit

  • Chores
    • Updated dependency version constraints for two backend packages to narrower, explicit ranges.
  • Chores
    • Adjusted the backend HTTP client timeout to an explicit millisecond-based value, increasing the effective timeout.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 6, 2026

Walkthrough

Updated composer.json dependency constraints: utopia-php/fetch changed from ^0.4.2 to 0.5.* and utopia-php/validators changed from ^0.1.0 to 0.1.*. In src/Audit/Adapter/ClickHouse.php the HTTP client timeout expression was changed from setTimeout(30) to setTimeout(30 * 1000) (milliseconds). No public API signatures were modified.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The PR title only references bumping utopia-php/fetch, but the changeset includes two distinct modifications: dependency version updates and a timeout unit conversion from seconds to milliseconds. Consider updating the title to reflect both changes, such as 'Bump utopia-php/fetch version and convert timeout to milliseconds' for better clarity on the full scope of changes.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
✨ Finishing touches
  • 📝 Generate docstrings

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 415b945 and 35112fe.

⛔ Files ignored due to path filters (1)
  • composer.lock is excluded by !**/*.lock
📒 Files selected for processing (2)
  • composer.json
  • src/Audit/Adapter/ClickHouse.php
🚧 Files skipped from review as they are similar to previous changes (1)
  • composer.json
🔇 Additional comments (1)
src/Audit/Adapter/ClickHouse.php (1)

75-75: The timeout change is correct and no other updates are needed.

The v0.5.1 dependency correctly expects milliseconds. The calculation (30 × 1,000 = 30,000 ms = 30 seconds) is accurate, the inline comment is clear, and this is the only setTimeout usage in the codebase.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@loks0n loks0n merged commit be9999d into main Jan 6, 2026
3 of 4 checks passed
@loks0n loks0n deleted the ser-728 branch January 6, 2026 15:03
hmacr added a commit that referenced this pull request Jan 6, 2026
This reverts commit be9999d, reversing
changes made to e973371.
loks0n added a commit that referenced this pull request Jan 6, 2026
Revert "Merge pull request #97 from utopia-php/ser-728"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants