Skip to content
Merged
Show file tree
Hide file tree
Changes from 6 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
117 changes: 117 additions & 0 deletions src/DNS/Validator/CAA.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,117 @@
<?php

namespace Utopia\DNS\Validator;

use Utopia\Validator;

class CAA extends Validator
{
public const int CAA_FLAG_MIN = 0;

public const int CAA_FLAG_MAX = 255;

public const string FAILURE_REASON_INVALID_FLAGS = 'Flags must be a number between 0 and 255';

public const string FAILURE_REASON_INVALID_TAG = 'Tag must be a non-empty string';

public const string FAILURE_REASON_INVALID_VALUE = 'Value must be a non-empty string and must be enclosed in quotes';

public const string FAILURE_REASON_INVALID_FORMAT = 'CAA record must be in the format flags tag "value"';

public string $reason = '';

/**
* Check if the provided value matches the CAA record format
*
* @param mixed $data
* @return bool
*/
public function isValid(mixed $data): bool
{
if (!is_string($data)) {
$this->reason = self::FAILURE_REASON_INVALID_FORMAT;
return false;
}

$parts = explode(" ", $data, 3);

if (count($parts) !== 3) {
$this->reason = self::FAILURE_REASON_INVALID_FORMAT;
return false;
}

$flags = $parts[0];
$tag = $parts[1];
$value = $parts[2];

// Check flags is a number
if (!is_numeric($flags)) {
$this->reason = self::FAILURE_REASON_INVALID_FLAGS;
return false;
}

$flags = (int) $flags;

// Check flags is within the allowed range
if ($flags < self::CAA_FLAG_MIN || $flags > self::CAA_FLAG_MAX) {
$this->reason = self::FAILURE_REASON_INVALID_FLAGS;
return false;
}

// Check tag is not empty
if (strlen($tag) === 0) {
$this->reason = self::FAILURE_REASON_INVALID_TAG;
return false;
}

// Check value is not empty and starts with " and ends with "
if (strlen($value) === 0 || $value[0] !== '"' || $value[strlen($value) - 1] !== '"') {
$this->reason = self::FAILURE_REASON_INVALID_VALUE;
return false;
}

$value = substr($value, 1, strlen($value) - 2);

// Check value is not empty after removing the quotes
if (strlen($value) === 0) {
$this->reason = self::FAILURE_REASON_INVALID_VALUE;
return false;
}

// All checks passed
return true;
}

public function getDescription(): string
{
if (!empty($this->reason)) {
return $this->reason;
}

return self::FAILURE_REASON_INVALID_FORMAT;
}

/**
* Is array
*
* Function will return true if object is array.
*
* @return bool
*/
public function isArray(): bool
{
return false;
}

/**
* Get Type
*
* Returns validator type.
*
* @return string
*/
public function getType(): string
{
return self::TYPE_STRING;
}
}
122 changes: 122 additions & 0 deletions src/DNS/Validator/Name.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,122 @@
<?php

namespace Utopia\DNS\Validator;

use Utopia\DNS\Message\Domain;
use Utopia\DNS\Message\Record;
use Utopia\Validator;

class Name extends Validator
{
private const array RECORD_TYPES_WITH_UNDERSCORE_IN_NAME = [Record::TYPE_SRV, Record::TYPE_TXT];

public const int LABEL_MAX_LENGTH = 63;

public const string FAILURE_REASON_INVALID_LABEL_LENGTH = 'Label must be between 1 and 63 characters long';

public const string FAILURE_REASON_INVALID_NAME_LENGTH = 'Name must be between 1 and 255 characters long';

public const string FAILURE_REASON_INVALID_LABEL_CHARACTERS = 'Label must contain only alpha-numeric characters and hyphens, and cannot start or end with a hyphen, and may contain underscore if the record type allows it';

public const string FAILURE_REASON_GENERAL = 'Name must be between 1 and 255 characters long, and contain only alpha-numeric characters and hyphens, and cannot start or end with a hyphen, and may contain underscore if the record type allows it';

public string $reason = '';

private int $recordType;

public function __construct(int $recordType)
{
$this->recordType = $recordType;
}

/**
* Check if the provided value matches the Name record format
*
* @param mixed $name
* @return bool
*/
public function isValid(mixed $name): bool
{
if (!\is_string($name)) {
$this->reason = self::FAILURE_REASON_GENERAL;
return false;
}

// DNS names are made up of labels separated by dots.
// Each label: 1-63 chars, letters, digits, hyphens, can't start/end w/ hyphen.
// Full name: <=255 chars, labels separated by single dots, no empty labels unless root.
// If the record type allows underscores in the name, they are allowed in the name.

if (\strlen($name) < 1 || \strlen($name) > Domain::MAX_DOMAIN_NAME_LEN) {
$this->reason = self::FAILURE_REASON_INVALID_NAME_LENGTH;
return false;
}

// If the name ends with '.', strip it (absolute FQDN); allow trailing '.'.
$trimmed = (\substr($name, -1) === '.') ? \substr($name, 0, -1) : $name;
$labels = \explode('.', $trimmed);

// Disallow empty label except root "." (which means $trimmed = '')
foreach ($labels as $label) {
if ($label === '') {
$this->reason = self::FAILURE_REASON_INVALID_LABEL_CHARACTERS;
return false;
}

if (\strlen($label) > self::LABEL_MAX_LENGTH) {
$this->reason = self::FAILURE_REASON_INVALID_LABEL_LENGTH;
return false;
}

// RFC: Only a-z 0-9 -, can't start or end with '-'
// May contain '_' if the record type allows it.
$len = \strlen($label);
// Check label contains only allowed chars
for ($i = 0; $i < $len; ++$i) {
if (!$this->isValidCharacter($label[$i], $i === 0 || $i === $len - 1)) {
$this->reason = self::FAILURE_REASON_INVALID_LABEL_CHARACTERS;
return false;
}
}
}

return true;
}

private function isValidCharacter(string $char, bool $isFirstOrLast): bool
{
$isUnderscoreAllowed = \in_array($this->recordType, self::RECORD_TYPES_WITH_UNDERSCORE_IN_NAME);
if ($isFirstOrLast) {
return \ctype_alnum($char) || ($isUnderscoreAllowed && $char === '_');
}
return \ctype_alnum($char) || $char === '-' || ($isUnderscoreAllowed && $char === '_');
}

/**
* @inheritDoc
*/
public function getDescription(): string
{
if (!empty($this->reason)) {
return $this->reason;
}

return self::FAILURE_REASON_GENERAL;
}

/**
* @inheritDoc
*/
public function getType(): string
{
return self::TYPE_STRING;
}

/**
* @inheritDoc
*/
public function isArray(): bool
{
return false;
}
}
45 changes: 45 additions & 0 deletions tests/unit/DNS/Validator/CAATest.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
<?php

namespace Tests\Unit\Utopia\DNS\Validator;

use PHPUnit\Framework\TestCase;
use Utopia\DNS\Validator\CAA;

final class CAATest extends TestCase
{
public function testValid(): void
{
$validator = new CAA();

$validValues = [
'0 issue "letsencrypt.org"',
'128 issuewild "certainly.com;account=123456;validationmethods=dns-01"',
'0 issuewild "certainly.com"',
'0 iodef "mailto:security@example.com"',
'0 issue ";"',
'0 issue "certainly.com; validationmethods=dns-01"',
];

foreach ($validValues as $value) {
$this->assertTrue($validator->isValid($value), "Expected valid: {$value}");
}
}

public function testInvalid(): void
{
$validator = new CAA();

$invalidValues = [
['value' => 'issue "letsencrypt.org"', 'description' => CAA::FAILURE_REASON_INVALID_FORMAT],
['value' => '0 ""', 'description' => CAA::FAILURE_REASON_INVALID_FORMAT],
['value' => '256 issue "letsencrypt.org"', 'description' => CAA::FAILURE_REASON_INVALID_FLAGS],
['value' => '0 issue letsencrypt.org', 'description' => CAA::FAILURE_REASON_INVALID_VALUE],
['value' => '0 issue ""', 'description' => CAA::FAILURE_REASON_INVALID_VALUE],
];

foreach ($invalidValues as $invalidValue) {
$this->assertFalse($validator->isValid($invalidValue['value']), "Expected invalid: {$invalidValue['value']}");
$this->assertSame($invalidValue['description'], $validator->getDescription());
}
}
}
59 changes: 59 additions & 0 deletions tests/unit/DNS/Validator/NameTest.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,59 @@
<?php

namespace Tests\Unit\Utopia\DNS\Validator;

use PHPUnit\Framework\TestCase;
use Utopia\DNS\Message\Record;
use Utopia\DNS\Validator\Name;

final class NameTest extends TestCase
{
public function testValid(): void
{
$validator = new Name(Record::TYPE_CNAME);

$validValues = [
'example',
'example.com',
'EXAMPLE.COM',
'a-b.com',
'a123.example-domain.org',
'xn--d1acufc.xn--p1ai',
'123.com',
'example.com.',
str_repeat('a', 63) . '.com',
];

foreach ($validValues as $value) {
$this->assertTrue($validator->isValid($value), "Expected valid: {$value}");
}

// Allowed underscores in name
$validator = new Name(Record::TYPE_SRV);
$this->assertTrue($validator->isValid('example._tcp.com'), "Expected valid: example._tcp.com");
}

public function testInvalid(): void
{
$validator = new Name(Record::TYPE_CNAME);

$invalidValues = [
['value' => 123, 'description' => Name::FAILURE_REASON_GENERAL],
['value' => '', 'description' => Name::FAILURE_REASON_INVALID_NAME_LENGTH],
['value' => str_repeat('a', 256) . '.com', 'description' => Name::FAILURE_REASON_INVALID_NAME_LENGTH],
['value' => str_repeat('a', 64) . '.com', 'description' => Name::FAILURE_REASON_INVALID_LABEL_LENGTH],
['value' => '-example.com', 'description' => Name::FAILURE_REASON_INVALID_LABEL_CHARACTERS],
['value' => 'example-.com', 'description' => Name::FAILURE_REASON_INVALID_LABEL_CHARACTERS],
['value' => 'exa_mple.com', 'description' => Name::FAILURE_REASON_INVALID_LABEL_CHARACTERS],
['value' => 'example..com', 'description' => Name::FAILURE_REASON_INVALID_LABEL_CHARACTERS],
['value' => '.example.com', 'description' => Name::FAILURE_REASON_INVALID_LABEL_CHARACTERS],
['value' => 'example.com..', 'description' => Name::FAILURE_REASON_INVALID_LABEL_CHARACTERS],
['value' => 'exa mple.com', 'description' => Name::FAILURE_REASON_INVALID_LABEL_CHARACTERS],
];

foreach ($invalidValues as $value) {
$this->assertFalse($validator->isValid($value['value']), "Expected invalid: {$value['value']}");
$this->assertSame($value['description'], $validator->getDescription());
}
}
}