Chore: Replace assertEquals with assertSame

[Meldiron]

Summary by CodeRabbit

• Tests
  • Enhanced test assertions across migration and data processing validations for improved type safety verification.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

This pull request refactors test assertions across four test files by replacing assertEquals() calls with assertSame() to enforce strict type-aware equality comparisons. The changes affect tests for NHost, Supabase, CSV, and Transfer functionality, ensuring both value and type match in assertions for status codes, hashes, algorithms, database properties, file metadata, and other test data. No control flow, data retrieval logic, or test behavior is altered—only the assertion methodology is tightened.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Rationale: This is a highly homogeneous refactoring pattern applied consistently across multiple test files. All changes follow the same mechanical substitution (assertEquals → assertSame), making them low-complexity and highly predictable. The scope, while spanning four files, is mitigated by the repetitive nature of the edits.

Areas requiring attention:

• Verify that all assertEquals() instances intended for strict type checking have been replaced (no selective application)
• Ensure the refactoring is complete and consistent across all four test files
• Confirm no unintended behavioral changes or assertion logic modifications occurred beyond the method replacement

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 6.67% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'Chore: Replace assertEquals with assertSame' directly and accurately summarizes the main change: systematic replacement of loose equality assertions with strict type-aware assertions across multiple test files.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch chore-assert-same

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f84a064 and 6d490c4.

📒 Files selected for processing (4)

• tests/Migration/E2E/Sources/NHostTest.php (6 hunks)
• tests/Migration/E2E/Sources/SupabaseTest.php (7 hunks)
• tests/Migration/Unit/General/CSVTest.php (8 hunks)
• tests/Migration/Unit/General/TransferTest.php (2 hunks)

🧰 Additional context used

🧠 Learnings (2)

📚 Learning: 2025-06-28T09:47:58.757Z

Learnt from: ItzNotABug
Repo: utopia-php/migration PR: 80
File: src/Migration/Sources/Supabase.php:300-308
Timestamp: 2025-06-28T09:47:58.757Z
Learning: In the utopia-php/migration codebase, during the terminology swap from Collection/Attribute/Document to Table/Column/Row, the user ItzNotABug prefers to keep the existing query logic unchanged even if it becomes semantically incorrect with the new naming. The focus is purely on resource type renaming, not on fixing logical issues that become apparent after the terminology change.

Applied to files:

• tests/Migration/E2E/Sources/SupabaseTest.php

📚 Learning: 2025-06-28T09:45:36.026Z

Learnt from: ItzNotABug
Repo: utopia-php/migration PR: 80
File: src/Migration/Resources/Database/Row.php:60-60
Timestamp: 2025-06-28T09:45:36.026Z
Learning: In the utopia-php/migration codebase, the `fromArray` method is not used on Row objects, so mismatches between `jsonSerialize()` output keys and `fromArray()` input expectations for Row class are not problematic.

Applied to files:

• tests/Migration/Unit/General/CSVTest.php

🧬 Code graph analysis (4)

tests/Migration/Unit/General/TransferTest.php (2)

src/Migration/Resources/Database/Database.php (1)

• getDatabaseName (84-87)

src/Migration/Resource.php (1)

• getId (169-172)

tests/Migration/E2E/Sources/SupabaseTest.php (10)

src/Migration/Resource.php (2)

• getStatus (205-208)
• getId (169-172)

src/Migration/Resources/Auth/User.php (1)

• getPasswordHash (106-109)

src/Migration/Resources/Auth/Hash.php (2)

• getHash (92-95)
• getAlgorithm (108-111)

src/Migration/Resources/Database/Database.php (2)

• getDatabaseName (84-87)
• getDatabase (99-102)

src/Migration/Resources/Database/Table.php (2)

• getTableName (96-99)
• getDatabase (91-94)

src/Migration/Resources/Storage/File.php (2)

• getFileName (91-94)
• getMimeType (106-109)

src/Migration/Resources/Database/Attribute.php (1)

• getSize (105-108)

src/Migration/Resources/Database/Column.php (1)

• getSize (105-108)

src/Migration/Resources/Database/Columns/Text.php (1)

• getSize (88-91)

src/Migration/Resources/Database/Row.php (1)

• getData (94-97)

tests/Migration/Unit/General/CSVTest.php (2)

src/Migration/Sources/CSV.php (1)

• delimiter (520-626)

src/Migration/Resource.php (1)

• getStatus (205-208)

tests/Migration/E2E/Sources/NHostTest.php (6)

src/Migration/Resource.php (2)

• getStatus (205-208)
• getId (169-172)

src/Migration/Resources/Auth/User.php (2)

• getPasswordHash (106-109)
• getUsername (98-101)

src/Migration/Resources/Auth/Hash.php (2)

• getHash (92-95)
• getAlgorithm (108-111)

src/Migration/Resources/Database/Database.php (2)

• getDatabaseName (84-87)
• getDatabase (99-102)

src/Migration/Resources/Database/Table.php (2)

• getTableName (96-99)
• getDatabase (91-94)

src/Migration/Resources/Storage/File.php (3)

• getFileName (91-94)
• getBucket (86-89)
• getMimeType (106-109)

🔇 Additional comments (4)

tests/Migration/Unit/General/TransferTest.php (1)

42-42: LGTM! Improved type safety with strict equality checks.

The migration from assertEquals() to assertSame() enforces strict type and value comparison, ensuring both the exception message and database properties are exactly the expected string types. This is a valuable improvement for catching type-related issues early.

Also applies to: 62-63

tests/Migration/E2E/Sources/NHostTest.php (1)

186-189: LGTM! Strict type checking properly applied.

All assertions correctly updated to assertSame() for strict type and value equality. The changes cover user authentication properties, database/table metadata, and storage file properties. Type signatures from the domain model getters confirm that all comparisons are type-safe, including the integer size comparison at line 312.

Also applies to: 212-214, 233-236, 261-264, 287-288, 307-312

tests/Migration/E2E/Sources/SupabaseTest.php (1)

167-169: LGTM! Consistent strict equality enforcement.

The transition to assertSame() is properly applied across all user, database, table, bucket, and file assertions. Type signatures align correctly, including the integer size comparison at line 317. The commented assertion at line 240 is also updated for consistency, which is good practice for maintaining code hygiene.

Also applies to: 193-195, 216-219, 240-240, 265-268, 293-293, 314-318

tests/Migration/Unit/General/CSVTest.php (1)

73-73: LGTM! Strict equality appropriate for CSV validation.

The migration to assertSame() correctly enforces strict type checking across delimiter detection, export status validation, and CSV data comparisons. The string comparisons (including '30', '0', 'null', 'true', 'false') are semantically correct since CSV parsing naturally produces string representations of values. Array comparisons using assertSame() for decoded JSON data (lines 405-406) properly validate both structure and content.

Also applies to: 108-108, 141-141, 144-146, 190-193, 236-236, 238-238, 282-286, 388-394, 405-406

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}