Throw current Exception

[fogelito]

Summary by CodeRabbit

• Refactor
  • Improved error handling mechanism in the Appwrite integration.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

This pull request modifies exception handling in the Appwrite migration source class. The catch block now rethrows the original Throwable directly instead of wrapping it in a new Exception, with the exception that HTTP 403 errors continue to throw a dedicated "Missing required scopes." Exception. The method's docblock is updated to reflect that it may throw Throwable in addition to Exception. The success path remains unchanged.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

• Exception handling pattern change: Verify that rethrowing the original Throwable doesn't break downstream error handling or logging that may have depended on the wrapped Exception type.
• 403 error code special case: Ensure the conditional logic for HTTP 403 errors is correctly preserved and doesn't inadvertently affect other error codes.
• Docblock accuracy: Confirm the updated docblock accurately reflects all possible exception types the method can throw.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'Throw current Exception' directly corresponds to the main change: modifying exception handling to rethrow the original Throwable instead of wrapping it in a new Exception.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch report-exeption

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a4b99c3 and e369450.

📒 Files selected for processing (1)

• src/Migration/Sources/Appwrite.php (2 hunks)

🔇 Additional comments (1)

src/Migration/Sources/Appwrite.php (1)

164-170: Update docblock and fix exception handling consistency in the report() method.

Adding @throws \Throwable changes the method's exception contract and creates inconsistency with other source implementations that only declare @throws \Exception. More critically, the 403 error case (line 195) loses the original exception's context by not setting it as the previous parameter. Align the implementation with other source adapters by either: (1) using catch(\Exception $e) instead of catch(\Throwable $e), or (2) if Throwable handling is necessary for this adapter, preserve the original exception context and update all implementations consistently.