use assertSame in tests

[hmacr]

Summary by CodeRabbit

• Tests
  • Enhanced test assertions for pool-related functionality to enforce stricter equality validation, ensuring more robust test coverage without affecting application behavior.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

This pull request updates test files in the Pools directory by replacing loose equality assertions (assertEquals) with strict equality assertions (assertSame) across three test classes: ConnectionTest, GroupTest, and PoolTest. The changes enforce strict type and value comparisons in test assertions. One minor value adjustment is noted in ConnectionTest where the expected default for getID changes from null to an empty string. No logic or control flow modifications are present.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: converting assertEquals to assertSame across all test files to enforce strict equality checks.

✨ Finishing touches

• 📝 Generate docstrings

---

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ad7d6ba and 38ca9e5.

📒 Files selected for processing (3)

• tests/Pools/ConnectionTest.php
• tests/Pools/GroupTest.php
• tests/Pools/PoolTest.php

🧰 Additional context used

🧬 Code graph analysis (3)

tests/Pools/ConnectionTest.php (1)

src/Pools/Connection.php (7)

• getID (29-32)
• setID (38-42)
• Connection (10-105)
• getResource (47-50)
• setResource (56-60)
• reclaim (84-91)
• destroy (97-104)

tests/Pools/GroupTest.php (2)

src/Pools/Group.php (6)

• get (30-33)
• reclaim (48-55)
• add (19-23)
• setReconnectAttempts (99-106)
• setReconnectSleep (112-119)
• use (66-72)

src/Pools/Pool.php (9)

• count (295-298)
• pop (218-274)
• reclaim (304-316)
• Pool (14-369)
• getReconnectAttempts (91-94)
• setReconnectAttempts (100-104)
• getReconnectSleep (109-112)
• setReconnectSleep (118-122)
• use (192-205)

tests/Pools/PoolTest.php (2)

src/Pools/Pool.php (8)

• count (295-298)
• pop (218-274)
• use (192-205)
• Pool (14-369)
• push (280-290)
• reclaim (304-316)
• isEmpty (345-348)
• isFull (353-356)

tests/Pools/ConnectionTest.php (1)

• testReclaim (80-101)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Tests

🔇 Additional comments (4)

tests/Pools/GroupTest.php (1)

55-116: LGTM! Strict assertions improve test reliability.

All changes consistently replace assertEquals with assertSame, enforcing strict type and value comparisons for integer counts and string resources. This aligns with PHP best practices for unit testing.

tests/Pools/PoolTest.php (1)

26-296: LGTM! Comprehensive strict assertion upgrade.

All scalar value assertions (integers, strings, booleans) have been consistently updated to use assertSame, enforcing strict type checking throughout the test suite. The array comparisons in testTelemetry (lines 291-293, 305-307) appropriately remain as assertEquals since array comparison doesn't require strict identity checks.

tests/Pools/ConnectionTest.php (2)

25-38: LGTM! Strict assertions plus bug fix.

The changes correctly update both the assertion method and the expected value. The switch from assertEquals with null to assertSame with '' fixes a test bug—the source code shows Connection::$id is initialized as an empty string, not null. The previous tests only passed due to loose comparison where null == '' evaluates to true.

---

43-138: LGTM! Consistent strict equality assertions.

All remaining assertions have been appropriately updated to use assertSame for strict type and value comparisons of strings and integers throughout the connection and pool interaction tests.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}