Revert "refactor: update AMQP connection handling to support Swoole and enhance test coverage"

[loks0n]

Reverts #48

Summary by CodeRabbit

• Refactor

  • Removed Swoole-based AMQP integration, consolidating on the standard AMQP implementation.
  • Tightened AMQP broker internals (reduced surface for extension).

• Chores

  • Updated AMQP library dependency to a maintained package version.
  • Cleaned Docker Compose by removing the amqp-swoole service and related dependency.

• Tests

  • Removed Swoole-specific end-to-end tests and associated tooling.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

Replaced AMQP library dependency in composer.json, removed Swoole-specific Docker service and dependencies, tightened visibility in AMQP broker, and deleted Swoole-based broker, tests, and worker script. No new services or features added; existing AMQP flow retained with private members and without Swoole integration.

Changes

Cohort / File(s)	Summary
Dependency update composer.json	Swapped appwrite-labs/php-amqplib (^0.1) for php-amqplib/php-amqplib (^3.7) in require.
Docker compose cleanup docker-compose.yml	Removed amqp-swoole service and its reference in services.tests.depends_on; minor EOF newline change.
AMQP broker visibility tightening src/Queue/Broker/AMQP.php	Changed promoted ctor params from protected readonly to private readonly; made $channel, $connectionConfigHook, $channelConfigHook private; withChannel changed from protected to private; no logic changes.
Removal of Swoole broker src/Queue/Broker/AMQPSwoole.php	Deleted AMQPSwoole class that extended AMQP and overrode withChannel for Swoole connections.
Test and server removal (Swoole) tests/Queue/E2E/Adapter/AMQPSwooleTest.php, tests/Queue/servers/AMQPSwoole/worker.php	Removed E2E tests and Swoole worker script for AMQPSwoole adapter.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor App
  participant AMQPBroker as AMQP Broker
  participant AMQPConn as AMQP Connection
  participant AMQPChan as AMQP Channel

  App->>AMQPBroker: publish(message)
  AMQPBroker->>AMQPConn: connect (host, port, creds)
  AMQPBroker->>AMQPChan: open/create channel
  AMQPBroker->>AMQPChan: basic_publish(message)
  AMQPBroker-->>App: ack/return

  Note over AMQPBroker,AMQPChan: Swoole-specific flow removed. Single non-Swoole path.

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• Revert "feat: add workerStop handling" #49: Adjusts AMQP::close() behavior; overlaps with AMQP broker internals modified here.
• refactor: update AMQP connection handling to support Swoole and enhance test coverage #48: Introduced AMQPSwoole and made AMQP members protected; this PR removes AMQPSwoole and re-privatizes members.

Suggested reviewers

• abnegate

Poem

I hop through queues where packets glide,
The Swoole winds calm, now eased aside.
Private burrows, tighter doors,
AMQP hums like before.
New carrots fetched from Packagist plains—
Thump-thump! The broker still remains. 🥕

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 0d61c06 and 7f908f1.

⛔ Files ignored due to path filters (1)

• composer.lock is excluded by !**/*.lock

📒 Files selected for processing (6)

• composer.json (1 hunks)
• docker-compose.yml (1 hunks)
• src/Queue/Broker/AMQP.php (2 hunks)
• src/Queue/Broker/AMQPSwoole.php (0 hunks)
• tests/Queue/E2E/Adapter/AMQPSwooleTest.php (0 hunks)
• tests/Queue/servers/AMQPSwoole/worker.php (0 hunks)

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch revert-48-feat-swoole-amqp-adapter

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}