hashsum, cksum: Move --check confliction to clap

[oech3]

Closes #10071

[RenjiSann]

Can you include this change in #10028 ?

[github-actions]

GNU testsuite comparison:

GNU test failed: tests/cksum/md5sum. tests/cksum/md5sum is passing on 'main'. Maybe you have to rebase?
Congrats! The gnu test tests/shuf/shuf-reservoir is no longer failing!
Congrats! The gnu test tests/sort/sort-stale-thread-mem is no longer failing!

[codspeed-hq]

Merging this PR will not alter performance

Summary

✅ 139 untouched benchmarks
⏩ 37 skipped benchmarks¹

---

_{Comparing oech3:hashsum-windows (cbf2e6b) with main (b93da48)²}

Footnotes

1. 37 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

2. No successful run was found on main (bc3b613) during the generation of this report, so b93da48 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

[github-actions]

GNU testsuite comparison:

GNU test failed: tests/cksum/md5sum. tests/cksum/md5sum is passing on 'main'. Maybe you have to rebase?
Congrats! The gnu test tests/shuf/shuf-reservoir is no longer failing!
Congrats! The gnu test tests/sort/sort-stale-thread-mem is no longer failing!

[github-actions]

GNU testsuite comparison:

GNU test failed: tests/cksum/md5sum. tests/cksum/md5sum is passing on 'main'. Maybe you have to rebase?
Congrats! The gnu test tests/shuf/shuf-reservoir is no longer failing!
Congrats! The gnu test tests/sort/sort-stale-thread-mem is no longer failing!

[github-actions]

GNU testsuite comparison:

Congrats! The gnu test tests/shuf/shuf-reservoir is no longer failing!
Congrats! The gnu test tests/sort/sort-stale-thread-mem is no longer failing!

[RenjiSann]

Not sure we should have merged that, if we're going back to manual validation for --text/--tag and cie 🤔

wdyt @oech3 ?

[oech3]

https://github.com/uutils/coreutils#goals says

Matching GNU's output (stdout and error code) exactly
Our key objectives include: Better error messages

clap does not provide the reason why are those flags conflicts (though I don't think GNU message is great...). If @sylvestre dislike clap's messages, I'll revert every thing at 1 commit.

I think we can reduce complexity of *.rs after clap-rs 5 without require bypass bug was fixed.

[sylvestre]

yeah, please revert
i prefer quality of the error messages

[oech3]

--tag --text:
clap:
error: the following required arguments were not provided:
  --untagged
gnu:
--text mode is only supported with --untagged

--warn:
clap:
error: the following required arguments were not provided:
  --check
gnu
cksum: the --warn option is meaningful only when verifying checksums

--text
clap:
error: the following required arguments were not provided:
  --untagged
gnu:
--text mode is only supported with --untagged

One of a clap's advantage is multiple errors like

--warn --text
clap:
error: the following required arguments were not provided:
  --check
  --untagged
gnu:
--text mode is only supported with --untagged

Is there any way to keep last one only?

[oech3]

--check --text
clap: error: the argument '--check' cannot be used with '--text'
gnu: cksum: --text mode is only supported with --untagged

cksum --check -a crc by clap is impossible yet.

[oech3]

@sylvestre I don't think GNU is much better at here. Would you evaluate #10041 (comment) ?