Skip to content

Conversation

@oech3
Copy link
Contributor

@oech3 oech3 commented Jan 4, 2026

No description provided.

@github-actions
Copy link

github-actions bot commented Jan 4, 2026

GNU testsuite comparison:

GNU test failed: tests/tty/tty-eof. tests/tty/tty-eof is passing on 'main'. Maybe you have to rebase?

@RenjiSann
Copy link
Collaborator

No need for separated PRs for cksum and hashsum here IMO, can you include the changes in #10042 ? (while keeping 2 separate commits if you prefer)

@oech3 oech3 force-pushed the hashsum-stdin-clap branch 2 times, most recently from 93da642 to 1aa7483 Compare January 6, 2026 10:40
@oech3
Copy link
Contributor Author

oech3 commented Jan 6, 2026

Done. Yes. we should keep them same.

@oech3 oech3 changed the title hashsum: Move default stdin to clap hashsum, cksum: Move default stdin to clap Jan 6, 2026
@github-actions
Copy link

github-actions bot commented Jan 6, 2026

GNU testsuite comparison:

Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/shuf/shuf-reservoir is no longer failing!
Congrats! The gnu test tests/sort/sort-stale-thread-mem is no longer failing!

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 6, 2026

CodSpeed Performance Report

Merging #10043 will degrade performance by 6.56%

Comparing oech3:hashsum-stdin-clap (0078c26) with main (44e0bba)

Summary

❌ 1 regression
✅ 138 untouched
⏩ 37 skipped1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Efficiency
cksum_blake3 210.2 µs 225 µs -6.56%

Footnotes

  1. 37 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@oech3
Copy link
Contributor Author

oech3 commented Jan 6, 2026

cksum_blake3 benches the error message given by clap. So it is not a performance regression.

@oech3 oech3 force-pushed the hashsum-stdin-clap branch from 1aa7483 to 0078c26 Compare January 6, 2026 14:32
@github-actions
Copy link

github-actions bot commented Jan 6, 2026

GNU testsuite comparison:

Congrats! The gnu test tests/shuf/shuf-reservoir is no longer failing!
Congrats! The gnu test tests/sort/sort-stale-thread-mem is no longer failing!

@RenjiSann RenjiSann merged commit 0f59f95 into uutils:main Jan 6, 2026
130 of 131 checks passed
@oech3 oech3 deleted the hashsum-stdin-clap branch January 6, 2026 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants