-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
i18n: conditionally load SELinux/Smack locale strings based on feature flag #10076
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
d406de3 to
d9700b8
Compare
|
Cannot we do it at |
CodSpeed Performance ReportMerging this PR will degrade performance by 3.55%Comparing Summary
Performance Changes
Footnotes
|
|
GNU testsuite comparison: |
|
@oech3 Can you elaborate on what you mean by that? |
|
|
|
Now that the SMACK changes are in I can also do this for the SMACK locale translations, I'll update this PR |
d9700b8 to
c358571
Compare
|
GNU testsuite comparison: |
One of the issues with enabling the Smack support is that adding the locale for the SMACK errors adds a bunch of overhead even to the non-SELINUX or SMACK enabled utilities. The goal here is to reduce the overhead of adding new shared locale files by gating them behind the feature flag.