Skip to content

Conversation

@oech3
Copy link
Contributor

@oech3 oech3 commented Dec 8, 2025

We can't build runcon and chcon without libselinux. But GNU no longer builds dummies of them. So move tests to Fedora VM: https://github.com/uutils/coreutils/actions/runs/20046833546/job/57494071620?pr=9607#step:15:34

Also some tests related with them were incorrectly passing due to false symlinks...

@github-actions
Copy link

github-actions bot commented Dec 8, 2025

GNU testsuite comparison:

Congrats! The gnu test tests/runcon/runcon-no-reorder is no longer failing!
Note: The gnu test tests/runcon/runcon-compute is now being skipped but was previously passing.

@oech3 oech3 force-pushed the patch-5 branch 2 times, most recently from 052b34e to fcf4e6b Compare December 8, 2025 23:34
@oech3 oech3 changed the title build-gnu.sh: Move {ch,run}con tests to SELinux MV and avoid wrong result build-gnu.sh: Move {ch,run}con tests to Fedora VM and avoid wrong result Dec 8, 2025
@github-actions
Copy link

github-actions bot commented Dec 8, 2025

GNU testsuite comparison:

Congrats! The gnu test tests/runcon/runcon-no-reorder is no longer failing!
Note: The gnu test tests/runcon/runcon-compute is now being skipped but was previously passing.

@github-actions
Copy link

github-actions bot commented Dec 9, 2025

GNU testsuite comparison:

GNU test failed: tests/runcon/runcon-compute. tests/runcon/runcon-compute is passing on 'main'. Maybe you have to rebase?
Congrats! The gnu test tests/runcon/runcon-no-reorder is no longer failing!

@oech3
Copy link
Contributor Author

oech3 commented Dec 9, 2025

Note that runcon-compute passes when runcon is false. This is not a regression.
This should be commented.

@github-actions
Copy link

GNU testsuite comparison:

GNU test failed: tests/runcon/runcon-compute. tests/runcon/runcon-compute is passing on 'main'. Maybe you have to rebase?
Congrats! The gnu test tests/runcon/runcon-no-reorder is no longer failing!
Congrats! The gnu test tests/tail/inotify-dir-recreate is now passing!

@sylvestre sylvestre merged commit ef496b6 into uutils:main Dec 20, 2025
128 of 129 checks passed
@oech3 oech3 deleted the patch-5 branch December 20, 2025 10:13
@sylvestre
Copy link
Contributor

@oech3 it caused a regression on GNU test failed: tests/runcon/runcon-compute. tests/runcon/runcon-compute is passing on 'main'. Maybe you have to rebase?
could you please have a look? thanks

@oech3
Copy link
Contributor Author

oech3 commented Dec 20, 2025

runcon-compute was incorrectly passing by symlinking false binary to runcon.

@oech3
Copy link
Contributor Author

oech3 commented Dec 20, 2025

So we should reset the result by someway. I don't know how to do that...

oech3 added a commit to oech3/coreutils that referenced this pull request Dec 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants