Skip to content

Conversation

@iburaky2
Copy link

See #9750

Similar to #9777 except destination uid & gid are checked after chown, this approach avoids having to use FnMut above. Not sure which approach is better.

Either way, GNU cp strips the setuid and setgid bits even when preserving ownership succeeds but preserving group fails (see second test)

@codspeed-hq
Copy link

codspeed-hq bot commented Dec 22, 2025

CodSpeed Performance Report

Merging #9781 will degrade performance by 4.4%

Comparing iburaky2:main (0e29cca) with main (836e5d1)

Summary

⚡ 1 improvement
❌ 1 regression
✅ 125 untouched
⏩ 6 skipped1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Efficiency
sort_ascii_c_locale 22.6 ms 21.5 ms +4.73%
mv_force_overwrite 138 ms 144.3 ms -4.4%

Footnotes

  1. 6 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@github-actions
Copy link

GNU testsuite comparison:

GNU test failed: tests/sort/sort-stale-thread-mem. tests/sort/sort-stale-thread-mem is passing on 'main'. Maybe you have to rebase?

@github-actions
Copy link

GNU testsuite comparison:

Congrats! The gnu test tests/printf/printf-surprise is now passing!
Note: The gnu test tests/dd/no-allocate was skipped on 'main' but is now failing.
Note: The gnu test tests/misc/write-errors was skipped on 'main' but is now failing.

@sylvestre
Copy link
Contributor

a few jobs are failing

@sylvestre
Copy link
Contributor

dup of #9777 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants