Skip to content

Conversation

@ChrisDryden
Copy link
Collaborator

@ChrisDryden ChrisDryden commented Dec 24, 2025

The only part of the tests that was failing for sort was the locale support for decimals. I figured since all of the utilities use the same library method for getting the locale separator it would be better to update the library instead of the individual function.

Ideally we will do the exact same approach for the thousands separator too, for the other GNU locale test

@ChrisDryden ChrisDryden changed the title sort: use locale decimal separator for general numeric sort sort: use locale decimal separator for general numeric parse Dec 24, 2025
@ChrisDryden ChrisDryden force-pushed the sort-float-locale-fix branch from e7b4aa2 to 5b4fd50 Compare December 24, 2025 05:32
@ChrisDryden ChrisDryden marked this pull request as ready for review December 24, 2025 05:41
@github-actions
Copy link

GNU testsuite comparison:

GNU test failed: tests/misc/sleep. tests/misc/sleep is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/seq/seq. tests/seq/seq is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/sort/sort-stale-thread-mem. tests/sort/sort-stale-thread-mem is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/tty/tty-eof. tests/tty/tty-eof is passing on 'main'. Maybe you have to rebase?
Congrats! The gnu test tests/sort/sort-float is no longer failing!

@ChrisDryden ChrisDryden marked this pull request as draft December 24, 2025 05:53
@ChrisDryden
Copy link
Collaborator Author

Darn, looks like this causes some issues

@sylvestre
Copy link
Contributor

and will need some tests too :)

@ChrisDryden
Copy link
Collaborator Author

Can you take a look at some of the non-draft ones?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants