Skip to content

Conversation

@FidelSch
Copy link
Contributor

When rm would error out for several different reasons, it used to follow a different ordering than GNU. Eg. if you ran coreutils rm -d . on a non-empty dir, it would complain "Refusing to remove '.'" while GNU would show "Directory not empty".

It should now follow a similar order to what GNU shows. (Is directory > Dir not empty > preserve-root > current/parent directory)

@codspeed-hq
Copy link

codspeed-hq bot commented Dec 24, 2025

CodSpeed Performance Report

Merging #9827 will improve performance by 3.3%

Comparing FidelSch:rm-error-priority (7f35680) with main (502f3b1)

Summary

⚡ 1 improvement
✅ 126 untouched
⏩ 6 skipped1

Benchmarks breakdown

Benchmark BASE HEAD Efficiency
cp_large_file[16] 360.9 µs 349.4 µs +3.3%

Footnotes

  1. 6 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@github-actions
Copy link

GNU testsuite comparison:

GNU test failed: tests/sort/sort-stale-thread-mem. tests/sort/sort-stale-thread-mem is passing on 'main'. Maybe you have to rebase?
Note: The gnu test tests/printf/printf-surprise is now being skipped but was previously passing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant