-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
sort: retest l10n sorting changes with updated benchmarks #9995
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
CodSpeed Performance ReportMerging #9995 will degrade performance by 94.31%Comparing Summary
Benchmarks breakdown
Footnotes
|
|
@sylvestre how would you feel about merging your changes now that the benchmarks are corrected? |
|
seems that https://github.com/uutils/coreutils/pull/9982/files#diff-e7bdf46e4a9e8a87200b91ae7a3eb7b406ac2d4388b70e108a7197ad93feaae9 is doing something similar for join (or the equivalent) in uucore in a new pr wdyt? |
|
Yea that should definitely be in a shared place and have benchmarks to make sure that the more locale stuff we roll out does not impact performance. I'll make an example PR. |
|
OK to land but please fix the jobs |
64c6343 to
a0a153a
Compare
a0a153a to
7531d74
Compare
|
GNU testsuite comparison: |
This PR was originally made by @sylvestre back in sept to measure the performance that adding localy sorting would have. When I was investigating why there was such a slowdown I found that the benchmarks were actually not working correctly because the locale would be set to the first locale in the tests instead of to what the env variable was set to.
Now that the benchmarks are updated, it shows that the performance decline for the c locale is negligible and that the only declines are when using the locale env variables. This it not even a "decline" per se because these sorts were not even working in the first place.