process: Fix tty resolving #578
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dezgeg
force-pushed
the
tty_fix
branch
2 times, most recently
from
aceffac to
3eae2f0
Compare
Current tty resolution can give wrong result e.g. if the process has closed all fds of its controlling terminal. The proper way to do it seems to be based on field in /proc/<pid>/stat, which gives a device number of the tty. Converting that to a device path requires parsing /proc/tty/drivers (according to strace of upstream ps). After this `ps`, `ps -x` and `ps -a` give same processes as upstream ps.
Contributor
|
Thanks! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #578 +/- ##
===========================
===========================
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current tty resolution can give wrong result e.g. if the process has closed all fds of its controlling terminal. The proper way to do it seems to be based on field in /proc//stat, which gives a device number of the tty. Converting that to a device path requires parsing /proc/tty/drivers (according to strace of upstream ps).
After this
ps,ps -xandps -agive same processes as upstream ps.