-
Notifications
You must be signed in to change notification settings - Fork 4
Implement TarOperation and TarParam foundations #49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Implement TarOperation and TarParam foundations #49
Conversation
clippy and cargo fmt
|
Just wanted to give this a bump, @kaladron or @sylvestre let me know if we need anything. |
|
Wanted to give this another bump @sylvestre @cakebaker. The PR after this I plan to rework the Clap arg processing so we can not only take care of @sylvestre suggestion to help make TarOperation more sane but also see if we can start addressing #55. |
|
Sorry, it's performance review season at work and a lot of things in life
are delayed at the moment.
…On Sun, Dec 14, 2025, 18:55 Nicholas Still ***@***.***> wrote:
*stillbeingnick* left a comment (uutils/tar#49)
<#49 (comment)>
Wanted to give this another bump @sylvestre <https://github.com/sylvestre>
@cakebaker <https://github.com/cakebaker>. The PR after this I plan to
rework the Clap arg processing so we can not only take care of @sylvestre
<https://github.com/sylvestre> suggestion to help make TarOperation more
sane but also see if we can start addressing #55
<#55>.
—
Reply to this email directly, view it on GitHub
<#49 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAC4FO5SVFIW4Q42Y4RDUID4BWXAJAVCNFSM6AAAAACM7IZVVWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTMNJRHAYTANZUHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
All good @sylvestre reviewed unless you are a maintainer now too @kaladron. But always open to more reviews. |
Removing for match loop going over all matched args. Moved to standard if get_* for specific matches.
|
@cakebaker Thank you for the review! Items requested in the review are taken care of. |
|
Every time I somehow forget to run clippy and fmt! I need CI for my brain. Should be good to go now. |
This PR builds on the great work done by @kaladron and lays out the foundation to enable adding operations and options moving forward. Leveraging rust enums and building behavioral control with the enum dispatch pattern.
There are 3 critical pieces to this foundational layer.
TarParams
TarOptions
TarOperation
While this is just the bones it will continue to morph and change as more functionality is built into tar.